Update the pydantic models for datasets and files.#37
Merged
Conversation
Member
|
@Essmaw Nice. Let me know when I can review and merge. |
Member
|
In For instance (inspired from documentation): class DatasetMetadata(BaseModel):
dataset_repository: DatasetRepository = Field(
...,
description=(
"Name of the source repository. "
"Allowed values: ZENODO, FIGSHARE, OSF, NOMAD, ATLAS, GPCRMD."
),
)
dataset_id_in_repository: str = Field(
...,
description="Unique identifier of the dataset in the source repository.",
)
@computed_field
def dataset_project(self) -> DatasetRepository:
"""Name of the project."""
return self.dataset_repository
@dataset_project.setter
def dataset_project(self, new_name: DatasetProject) -> None:
self.dataset_project = new_name
@computed_field
def dataset_id_in_project(self) -> str:
"""ID of the project."""
return self.dataset_id_in_repository
@dataset_project.setter
def dataset_id_in_project(self, new_id: str) -> None:
self.dataset_id_in_project = new_id |
…ty in DatasetMetadata model + Set dataset project name and id optional.
Member
|
This sounds good @Essmaw 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply suggested modifications from @pierrepo.